pingtimeout commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2081153914
########## quarkus/common/build.gradle.kts: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + alias(libs.plugins.jandex) +} + +configurations.all { + exclude(group = "org.antlr", module = "antlr4-runtime") + exclude(group = "org.scala-lang", module = "scala-library") + exclude(group = "org.scala-lang", module = "scala-reflect") +} + +java { + sourceCompatibility = JavaVersion.VERSION_21 + targetCompatibility = JavaVersion.VERSION_21 Review Comment: > these module gets build with 23 which is correct Well, actually, this is not correct. Although Polaris _can_ be built with any JDK ≥21, [the target version must be 21](https://github.com/apache/polaris/blob/9377aa731a64d6262dc7cc177d8a457d14c46f0a/build-logic/src/main/kotlin/polaris-server.gradle.kts#L24). AFAICT, [this](https://github.com/apache/polaris/blob/38013e49bd9edc24db4a706e0e8fe5bd4ed2a885/quarkus/common/build.gradle.kts) is the build file that was used by the CI job you linked. It does not contain any directive that pulls the common settings defined in polaris-quarkus, which is most likely the cause of the error. Robert's suggestion is that you probably want to add `id("polaris-quarkus")` inside the `plugins` block of polaris/quarkus/common/build.gradle.kts`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
