jbonofre commented on code in PR #1565:
URL: https://github.com/apache/polaris/pull/1565#discussion_r2083767628


##########
NOTICE:
##########
@@ -7,3 +7,18 @@ The Apache Software Foundation (http://www.apache.org/).
 The initial code for the Polaris project was donated
 to the ASF by Snowflake Inc. (https://www.snowflake.com/) copyright 2024.
 
+--------------------------------------------------------------------------------
+
+This project includes code from Apache Iceberg, with the following
+copyright notice:
+
+| Apache Iceberg
+| Copyright 2017-2025 The Apache Software Foundation
+
+--------------------------------------------------------------------------------
+
+This project includes code from Project Nessie, developed at Dremio,
+with the following copyright notice:
+
+| Nessie
+| Copyright 2015-2025 Dremio Corporation

Review Comment:
   The Nessie NOTICE (https://github.com/projectnessie/nessie/blob/main/NOTICE) 
mentions:
   1. Apache Iceberg
   2. Netty
   From Nessie, as listed in the Polaris `LICENSE`, we are just using the build 
resources (in `build-logic`).
   Iceberg or Netty are not used in Nessie `build-logic`, not in the code 
copied.
   
   So, that's exactly why I previously removed both Iceberg and Nessie NOTICE 
mention (copyright is in the `LICENSE` not in the `NOTICE`). And that's why I'm 
confused by your reply on the mailing list (regarding this).
   
   Imho, why I did before is better (simply removing Iceberg and Nessie from 
`NOTICE`), as nothing from Iceberg or Nessie `NOTICE` apply to Polaris.
   
   Thoughts ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to