dimas-b commented on code in PR #1566:
URL: https://github.com/apache/polaris/pull/1566#discussion_r2084652846
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GetConfigTest.java:
##########
@@ -39,7 +39,14 @@ public class GetConfigTest {
@ValueSource(booleans = {true, false})
public void testGetConfig(boolean enableGenericTable) {
TestServices services =
- TestServices.builder().config(Map.of("ENABLE_GENERIC_TABLES",
enableGenericTable)).build();
+ TestServices.builder()
+ .config(
+ Map.of(
+ "ENABLE_GENERIC_TABLES",
+ enableGenericTable,
+ "SUPPORTED_CATALOG_STORAGE_TYPES",
Review Comment:
For Quarkus test, I believe it should be possible to put this setting in a
test profile in `application-test.properties` and/or
`application-it.properties` and reduce the amount of code changes in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
