dimas-b commented on code in PR #1557:
URL: https://github.com/apache/polaris/pull/1557#discussion_r2085798458


##########
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##########
@@ -75,7 +75,7 @@ public void testConfigsCanBeCastedFromString() {
   public void testInvalidCastThrowsException() {
     // Bool not included because Boolean.valueOf turns non-boolean strings to 
false
     List<PolarisConfiguration<?>> configs =
-        List.of(buildConfig("int", 12), buildConfig("long", 34L), 
buildConfig("double", 5.6D));
+        List.of(buildConfig("int2", 12), buildConfig("long2", 34L), 
buildConfig("double2", 5.6D));

Review Comment:
   nit: Why do we need to rename these test properties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to