HonahX commented on code in PR #1529:
URL: https://github.com/apache/polaris/pull/1529#discussion_r2096215517
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -621,6 +623,19 @@ public Response addGrantToCatalogRole(
adminService.grantPrivilegeOnCatalogToRole(catalogName,
catalogRoleName, privilege);
break;
}
+ case PolicyGrant policyGrant:
+ {
Review Comment:
Maybe the current way makes it a little bit harder to review. I include both
in the same PR to ensure we have test to cover that all the names and grants
added to the spec is correct. Given that there has been lots of review going
on, would you be okay to keep it in one for this time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
