gh-yzou commented on code in PR #1505: URL: https://github.com/apache/polaris/pull/1505#discussion_r2096588190
########## service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStoreDecorator.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.config; + +import com.fasterxml.jackson.databind.ObjectMapper; +import jakarta.annotation.Nonnull; +import jakarta.annotation.Nullable; +import jakarta.annotation.Priority; +import jakarta.decorator.Decorator; +import jakarta.decorator.Delegate; +import jakarta.enterprise.inject.Instance; +import jakarta.inject.Inject; +import java.util.Map; +import org.apache.polaris.core.PolarisCallContext; +import org.apache.polaris.core.config.PolarisConfigurationStore; +import org.apache.polaris.core.context.RealmContext; + +@Decorator +@Priority(1) +public class DefaultConfigurationStoreDecorator implements PolarisConfigurationStore { + @Inject @Delegate PolarisConfigurationStore delegate; + + private final Map<String, Object> defaults; + private final Map<String, Map<String, Object>> realmOverrides; + @Inject private Instance<RealmContext> realmContextInstance; Review Comment: That is a good point. The decorator is mainly used to provide customized implementations of a bean, in that case, we can keep the DefaultConfigurationStore purpose clear that it is an application level class that doesn't provide any realm override support, and the customized implementation provides capabilities for realm overrides, and in the future we can have other customized implementations, this can make the structure more clear. Of course, since we only have one customized implementation now, I do not see much benefit of doing it now also, i am open to just have one DefaultConfigurationStore with the injection also, @collado-mike what do you think? do you have strong opinion to keep the delegate implementation ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
