flyrain commented on PR #1624: URL: https://github.com/apache/polaris/pull/1624#issuecomment-2895230378
> The config option `INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST` is still configured in a bunch of places. Good catch. Removed them in the new commit. > The only obvious reason for `IcebergCatalog.catalogFileIO` and `getIo()` is to be a convenience for some test classes. I'd prefer to remove that field and method from `IcebergCatalog` and add the necessary pieces to the test classes that need it. Those can create a FileIO instance and close it after usage. That's fair point. Not only `getIo()`, but also `newTableOps()` and `newViewOps()` are test-only. I added a `@VisibleForTesting` so that they are labeled now. We can move it out in a follow-up PR if needed. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
