flyrain commented on code in PR #1532:
URL: https://github.com/apache/polaris/pull/1532#discussion_r2100733037


##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -2590,4 +2574,11 @@ private PageToken buildPageToken(@Nullable String 
tokenString, @Nullable Integer
       return PageToken.build(tokenString, pageSize);
     }
   }
+
+  static final FeatureConfiguration<Boolean> 
INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST =
+      PolarisConfiguration.<Boolean>builder()
+          .key("INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST")
+          .defaultValue(false)
+          .description("")
+          .buildFeatureConfiguration();

Review Comment:
   This part of the change is completely unnecessary in this PR and makes more 
conflicts for follow-ups like #1624. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to