adutra commented on code in PR #1638: URL: https://github.com/apache/polaris/pull/1638#discussion_r2100772068
########## helm/polaris/README.md.gotmpl: ########## @@ -101,27 +95,24 @@ The below instructions assume a local Kubernetes cluster is running and Helm is #### Common setup -Create and populate the target namespace: +Create the target namespace: ```bash kubectl create namespace polaris -kubectl apply --namespace polaris -f helm/polaris/ci/fixtures/ - -kubectl wait --namespace polaris --for=condition=ready pod --selector=app.kubernetes.io/name=postgres --timeout=120s ``` -The `helm/polaris/ci` contains a number of values files that can be used to install the chart with -different configurations. - -You can also run `ct` (chart-testing): - -```bash -ct lint --charts helm/polaris -ct install --namespace polaris --debug --charts ./helm/polaris -``` +Create all the required resources in the `polaris` namespace. This usually includes a Postgres Review Comment: The resources in question are _test_ resources. Instructing people to create them when installing Polaris would mean that they would end up with a bogus persitence.xml secret, a bogus TLS secret, a bogus storage secret, and a completely unprotected Postgres instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
