flyrain commented on code in PR #1643:
URL: https://github.com/apache/polaris/pull/1643#discussion_r2101423240


##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java:
##########
@@ -507,20 +507,28 @@ public class PolarisAuthorizerImpl implements 
PolarisAuthorizer {
             POLICY_FULL_METADATA,
             CATALOG_MANAGE_METADATA,
             CATALOG_MANAGE_CONTENT));
-    SUPER_PRIVILEGES.putAll(POLICY_ATTACH, List.of(POLICY_ATTACH, 
CATALOG_MANAGE_CONTENT));
-    SUPER_PRIVILEGES.putAll(POLICY_DETACH, List.of(POLICY_DETACH, 
CATALOG_MANAGE_CONTENT));
     SUPER_PRIVILEGES.putAll(
-        CATALOG_ATTACH_POLICY, List.of(CATALOG_ATTACH_POLICY, 
CATALOG_MANAGE_CONTENT));
+        POLICY_ATTACH, List.of(POLICY_ATTACH, CATALOG_MANAGE_METADATA, 
CATALOG_MANAGE_CONTENT));
     SUPER_PRIVILEGES.putAll(
-        NAMESPACE_ATTACH_POLICY, List.of(NAMESPACE_ATTACH_POLICY, 
CATALOG_MANAGE_CONTENT));
+        POLICY_DETACH, List.of(POLICY_DETACH, CATALOG_MANAGE_METADATA, 
CATALOG_MANAGE_CONTENT));

Review Comment:
   The change looks good to me, but Github did something weird here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to