flyrain commented on code in PR #1648: URL: https://github.com/apache/polaris/pull/1648#discussion_r2101638983
########## regtests/run_spark_sql.sh: ########## @@ -52,6 +52,10 @@ export SPARK_LOCAL_HOSTNAME=localhost # avoid VPN messing up driver local IP add ./setup.sh +if [ -z `which logred` ]; then + function logred() { echo $'\u001b'[0\;31m$*$'\u001b'[m; } +fi Review Comment: I'd lean to replace `logred` with `echo`, which is simpler and more portable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org