ajantha-bhat commented on code in PR #1651:
URL: https://github.com/apache/polaris/pull/1651#discussion_r2102287097


##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewFileIntegrationTest.java:
##########
@@ -18,20 +18,32 @@
  */
 package org.apache.polaris.service.it.test;
 
+import java.nio.file.Path;
 import java.util.List;
 import org.apache.polaris.core.admin.model.FileStorageConfigInfo;
 import org.apache.polaris.core.admin.model.StorageConfigInfo;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.io.TempDir;
 
 /** Runs PolarisRestCatalogViewIntegrationTest on the local filesystem. */
-public class PolarisRestCatalogViewFileIntegrationTest
+public abstract class PolarisRestCatalogViewFileIntegrationTest

Review Comment:
   nit: do we need to change the name to include `base` suffix once we change 
to abstract? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to