singhpk234 commented on code in PR #1646:
URL: https://github.com/apache/polaris/pull/1646#discussion_r2103066000
##########
getting-started/jdbc/docker-compose.yml:
##########
@@ -29,18 +29,22 @@ services:
# Optional, allows attaching a debugger to the Polaris JVM
- "5005:5005"
environment:
- - JAVA_DEBUG=true
Review Comment:
> Do any other docker-compose files need this fix? For example
getting-started/eclipselink/docker-compose.yml
yes, we do, added that !
> I wonder why this format change is required even in this PR 🤔
I tried the following syntax, with the new variables and aparently it didn't
work for me, didn't debug it further and hence for consistency moved everything
back to the format that worked :
```
- POLARIS_FEATURES_ALLOW_INSECURE_STORAGE_TYPES=true
-
POLARIS_FEATURES_SUPPORTED_CATALOG_STORAGE_TYPES=[\"FILE\",\"S3\",\"GCS\",\"AZURE\"]
- POLARIS_READINESS_IGNORE_SEVERE_ISSUES=true
```
> ? YAML is always confusing to me
same here, I am working on hit and trial basis here :), this worked and
hence i moved, i can definetly take a deeper look !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
