flyrain commented on PR #1589:
URL: https://github.com/apache/polaris/pull/1589#issuecomment-2902526329
I ran a quick size check: the admin-tool weighs in at ~100 MB and the server
at ~200 MB. After merging, the combined package is still ~200 MB, which tells
us the server’s lib set is essentially a superset of the admin’s.
If we merge the shared libs we get:
1. ~100 MB savings in the overall binary distribution (compressed package is
~280 MB, so compression doesn’t change the picture much).
2. The standalone admin-tool would carry an extra ~100 MB—even if someone
only needs the admin-tool. Personally, I think that’s an acceptable overhead.
WDYT?
“The two products will become intertwined, forcing operators to install
everything even if they only need one.”
They shouldn’t be intertwined beyond a shared lib/ directory, my plan is to
only merge the `/lib/main` dir. Anyway, I’m not proposing to merge anything in
this PR. Happy to keep discussing in a follow-up PR.
```
ygu@FM4LQ4GJ90 admin % du -h
456K ./quarkus
20K ./app
1.2M ./lib/boot
105M ./lib/main
106M ./lib
106M .
ygu@FM4LQ4GJ90 server % du -h
4.2M ./quarkus
8.0K ./app
1.3M ./lib/boot
201M ./lib/main
202M ./lib
205M .
# the merged one
ygu@FM4LQ4GJ90 admin % du -h
456K ./quarkus
20K ./app
1.2M ./lib/boot
202M ./lib/main
203M ./lib
203M .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
