flyrain commented on code in PR #1659: URL: https://github.com/apache/polaris/pull/1659#discussion_r2103769050
########## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ########## @@ -169,10 +169,10 @@ public class IcebergCatalog extends BaseMetastoreViewCatalog private final SecurityContext securityContext; private final PolarisEventListener polarisEventListener; - protected String ioImplClassName; - protected FileIO catalogFileIO; - protected CloseableGroup closeableGroup; - protected Map<String, String> tableDefaultProperties; + private String ioImplClassName; + private FileIO catalogFileIO; + private CloseableGroup closeableGroup; + private Map<String, String> tableDefaultProperties; Review Comment: nit: we could remove this empty line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
