dimas-b commented on code in PR #1695: URL: https://github.com/apache/polaris/pull/1695#discussion_r2111971029
########## gradle/projects.main.properties: ########## @@ -25,14 +25,14 @@ polaris-api-management-model=api/management-model polaris-api-management-service=api/management-service polaris-api-catalog-service=api/polaris-catalog-service polaris-service-common=service/common -polaris-quarkus-defaults=quarkus/defaults -polaris-quarkus-service=quarkus/service -polaris-quarkus-server=quarkus/server -polaris-quarkus-distribution=quarkus/distribution -polaris-quarkus-spark-tests=quarkus/spark-tests -polaris-quarkus-admin=quarkus/admin -polaris-quarkus-common=quarkus/common -polaris-quarkus-test-commons=quarkus/test-commons +polaris-defaults=runtime/defaults Review Comment: This particular rename might be losing some context. `polaris-quarkus-defaults` implied defaults for the Quarkus build/runtime but `polaris-defaults` is too generic, I guess... How about `polaris-assembly-defaults` (`runtime/assembly-defaults`)? This modules contains some config defaults for the runtime, but more importantly some build-time defaults too (e.g. the banner), hence the term "assembly". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
