dimas-b commented on code in PR #1758:
URL: https://github.com/apache/polaris/pull/1758#discussion_r2121873050


##########
service/common/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -206,11 +207,12 @@ private Stream<TaskEntity> getMetadataTaskStream(
       FileIO fileIO,
       IcebergTableLikeEntity tableEntity,
       PolarisMetaStoreManager metaStoreManager,
-      PolarisCallContext polarisCallContext) {
+      PolarisCallContext polarisCallContext,
+      String realm) {

Review Comment:
   My concern is more about potentially confusing realm ID is this new `realm` 
parameter and the implicit realm ID inside `PolarisCallContext` (even if it 
does not hold it as a field).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to