gh-yzou commented on code in PR #1758:
URL: https://github.com/apache/polaris/pull/1758#discussion_r2121950912
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -65,6 +76,35 @@ public interface PolarisConfigurationStore {
return configValue != null ? configValue : defaultValue;
}
+ /**
+ * Retrieve the current value for a configuration key for a given realm. May
be null if not set.
+ *
+ * @param realmContext the realm context
+ * @param configName the name of the configuration key to check
+ * @return the current value set for the configuration key for the given
realm, or null if not set
+ * @param <T> the type of the configuration value
+ */
+ default <T> @Nullable T getConfiguration(@Nonnull RealmContext realmContext,
String configName) {
Review Comment:
The PolarisCallContext is actually not used anywhere during
getConfiguration, and only realmContext is needed. So i think we should
deprecate the usage of the methods that uses PolarisCallContext, and i plan to
remove the usages step by step in follow up PRs, remove all of them in one PR
makes the change really big and touches persistent. i can mark the other APIs
as deprecated for now if that helps, would that work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
