fivetran-kostaszoumpatianos commented on code in PR #1772:
URL: https://github.com/apache/polaris/pull/1772#discussion_r2122006354
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -212,6 +212,14 @@ public IcebergCatalog(
this.polarisEventListener = polarisEventListener;
}
+ @Override
+ public boolean tableExists(TableIdentifier identifier) {
+ if (isValidIdentifier(identifier)) {
+ return newTableOps(identifier).current() != null;
Review Comment:
This kind of defies the purpose, as this will call
BaseMetastoreCatalog::loadTable and this will try to resolve the table as a
metadata table - if it doesn't exist. We should avoid that if we want to allow
Polaris to create tables named after these keywords.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
