adutra commented on PR #1765:
URL: https://github.com/apache/polaris/pull/1765#issuecomment-2932487796

   > The connection is that the TokenBroker bean is RequestScoped and it does 
create a BasePersistence Supplier
   
   I still don't see any `TokenBroker` creating any `BasePersistence` anywhere 
in the code 🤔 
   
   @adnanhemani as it stands, this PR is imo not mergeable: it has no clear 
error description, no stack trace that we can investigate, no reproducer, and 
no test case (`CachedSupplierTest` is just a unit test, but there is no test 
that shows evidence of a broken behavior that would be "fixed" by the proposed 
changes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to