gh-yzou commented on code in PR #1780:
URL: https://github.com/apache/polaris/pull/1780#discussion_r2122359393
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##########
@@ -164,22 +163,25 @@ public void testEntityOverrides() {
PolarisConfigurationStore store =
new PolarisConfigurationStore() {
@Override
- public <T> @Nullable T getConfiguration(PolarisCallContext ctx,
String configName) {
+ public <T> @Nullable T getConfiguration(RealmContext realmContext,
String configName) {
//noinspection unchecked
return (T) Map.of("key2", "config-value2").get(configName);
}
};
- PolarisCallContext ctx = null;
CatalogEntity entity =
new CatalogEntity.Builder()
.addProperty("polaris.config.catalog-key3", "entity-new3")
.addProperty("legacy-key4", "entity-legacy4")
.build();
- Assertions.assertEquals("test-default1", store.getConfiguration(ctx,
entity, cfg.apply(1)));
- Assertions.assertEquals("config-value2", store.getConfiguration(ctx,
entity, cfg.apply(2)));
- Assertions.assertEquals("entity-new3", store.getConfiguration(ctx, entity,
cfg.apply(3)));
- Assertions.assertEquals("entity-legacy4", store.getConfiguration(ctx,
entity, cfg.apply(4)));
+ Assertions.assertEquals(
+ "test-default1", store.getConfiguration(testRealmContext, entity,
cfg.apply(1)));
Review Comment:
sg! I will update this in my part 2 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
