flyrain commented on code in PR #1806:
URL: https://github.com/apache/polaris/pull/1806#discussion_r2125737257
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisCallContext.java:
##########
@@ -22,13 +22,15 @@
import java.time.Clock;
import java.time.ZoneId;
import org.apache.polaris.core.config.PolarisConfigurationStore;
+import org.apache.polaris.core.context.CallContext;
+import org.apache.polaris.core.context.RealmContext;
import org.apache.polaris.core.persistence.BasePersistence;
/**
* The Call context is allocated each time a new REST request is processed. It
contains instances of
* low-level services required to process that request
*/
-public class PolarisCallContext {
+public class PolarisCallContext implements CallContext {
Review Comment:
I think that's also a nice idea, however, it will need to change
`CallContext` from an interface to a class, which isn't trivial -- all
anonymous classes have to go. Besides, it's reasonable to keep CallContext as
an interface, while `PolarisCallContext` as an impl. I also list the step 3
which promotes methods in `PolarisCallContext` to the interface `CallContext`,
like `getMetaStore()`. This will even clean up more, so that,
`PolarisCallContext` doesn't have to return itself from the method
`getPolarisCallContext()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
