HonahX commented on code in PR #1810:
URL: https://github.com/apache/polaris/pull/1810#discussion_r2127821351
##########
polaris:
##########
@@ -30,14 +30,17 @@ for arg in "$@"; do
fi
done
+# Check if the python client needs regeneration
+if [ "$repair" == true ] || [ ! -f
"${dir}/client/python/polaris/catalog/__init__.py" ]; then
+ ./gradlew regeneratePythonClient
Review Comment:
The generation will likely fails if user use MacOS, due to the `.DS_Store`
file thing : (.
This is not our fault, but to ensure a smoother installation experiences,
shall we consider cleaning the folder before regenerating here or add
`.DS_Store`, `poetry.lock` to the `EXCLUDE_PATHS`/`EXCLUDE_EXTENSION` in the
`regenerate.sh`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
