gh-yzou commented on code in PR #1816:
URL: https://github.com/apache/polaris/pull/1816#discussion_r2128014409
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisCallContext.java:
##########
@@ -94,4 +94,13 @@ public RealmContext getRealmContext() {
public PolarisCallContext getPolarisCallContext() {
return this;
}
+
+ @Override
+ public PolarisCallContext copy() {
+ // make a copy of the realm context
Review Comment:
yes, added, please take a look and see if it make sense
##########
service/common/src/testFixtures/java/org/apache/polaris/service/TestServices.java:
##########
@@ -163,22 +163,12 @@ public TestServices build() {
BasePersistence metaStoreSession =
metaStoreManagerFactory.getOrCreateSessionSupplier(realmContext).get();
CallContext callContext =
- new CallContext() {
- @Override
- public RealmContext getRealmContext() {
- return realmContext;
- }
-
- @Override
- public PolarisCallContext getPolarisCallContext() {
- return new PolarisCallContext(
- realmContext,
- metaStoreSession,
- polarisDiagnostics,
- configurationStore,
- Mockito.mock(Clock.class));
- }
- };
+ new PolarisCallContext(
+ realmContext,
+ metaStoreSession,
+ polarisDiagnostics,
+ configurationStore,
+ Mockito.mock(Clock.class));
Review Comment:
sg! updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
