dimas-b commented on code in PR #1783:
URL: https://github.com/apache/polaris/pull/1783#discussion_r2128794818
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##########
@@ -175,13 +175,9 @@ public void testEntityOverrides() {
.addProperty("legacy-key4", "entity-legacy4")
.build();
- Assertions.assertEquals(
- "test-default1", store.getConfiguration(testRealmContext, entity,
cfg.apply(1)));
- Assertions.assertEquals(
- "config-value2", store.getConfiguration(testRealmContext, entity,
cfg.apply(2)));
- Assertions.assertEquals(
- "entity-new3", store.getConfiguration(testRealmContext, entity,
cfg.apply(3)));
- Assertions.assertEquals(
- "entity-legacy4", store.getConfiguration(testRealmContext, entity,
cfg.apply(4)));
+ Assertions.assertEquals("test-default1", store.getConfiguration(null,
entity, cfg.apply(1)));
Review Comment:
This looks functionally correct to me, but it contracts the `@Nonnull`
annotation on the realm context parameter now :shrug: Let's go back to
`testRealmContext` to be aligned with annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
