flyrain commented on code in PR #1834: URL: https://github.com/apache/polaris/pull/1834#discussion_r2136008430
########## plugins/spark/v3.5/spark/LICENSE: ########## @@ -202,124 +202,368 @@ -------------------------------------------------------------------------------- -This product includes a gradle wrapper. - -* gradlew -* gradle/wrapper/gradle-wrapper.properties - -Copyright: 2010-2019 Gradle Authors. -Home page: https://github.com/gradle/gradle -License: https://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- - This product includes code from Apache Iceberg. -* spec/iceberg-rest-catalog-open-api.yaml -* spec/polaris-catalog-apis/oauth-tokens-api.yaml -* integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java -* service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java -* service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java * plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java * plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/PolarisInMemoryCatalog.java Review Comment: These two lines are also not needed per offline discussion, as they don't copy any code from Iceberg. Can you confirm, @gh-yzou ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
