gh-yzou commented on code in PR #1857:
URL: https://github.com/apache/polaris/pull/1857#discussion_r2141133350


##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,7 +151,7 @@ tasks.register("checkNoDisallowedImports") {
 tasks.named("check") { dependsOn("checkNoDisallowedImports") }
 
 tasks.register<ShadowJar>("createPolarisSparkJar") {
-  archiveClassifier = "bundle"
+  archiveClassifier = null

Review Comment:
   the original name is something like 
polaris-spark-3.5_2.12-0.11.0-beta-incubating-SNAPSHOT-bundle.jar, we did this 
because the jar without classifier is taken by the default jar job with name 
polaris-spark-3.5_2.12-0.11.0-beta-incubating-SNAPSHOT.jar. However, Spark does 
not support using classifier in the package config, so we make this jar the jar 
for this project, since this jar is the actual jar needed by spark, i think it 
actually should be the jar project without any classifier



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to