eric-maynard commented on code in PR #1838: URL: https://github.com/apache/polaris/pull/1838#discussion_r2145668181
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/EntityIdPaging.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.pagination; + +import static com.google.common.base.Preconditions.checkArgument; + +import jakarta.annotation.Nullable; +import org.apache.polaris.core.entity.PolarisBaseEntity; + +/** Utility class for processing pagination of streams of entities ordered by some ID property. */ +public final class EntityIdPaging { Review Comment: > but that is something to be done if and when we need it We have a (smaller) existing PR in #1555 that supports this use case, so I have some reservations about an alternative design that loses this functionality ########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/EntityIdPaging.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.pagination; + +import static com.google.common.base.Preconditions.checkArgument; + +import jakarta.annotation.Nullable; +import org.apache.polaris.core.entity.PolarisBaseEntity; + +/** Utility class for processing pagination of streams of entities ordered by some ID property. */ +public final class EntityIdPaging { Review Comment: > but that is something to be done if and when we need it We have an existing PR in #1555 that supports this use case, so I have some reservations about an alternative design that loses this functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
