eric-maynard commented on PR #1796: URL: https://github.com/apache/polaris/pull/1796#issuecomment-2977998107
Hey Dmitri, apologies if that wording was not the best. That standardization is happening in code. For example, I would say that we have standardized on using the name `LOGGER` for logger objects. We've standardized on a sort of 3-level structure for catalogs (Adapter, Handler, Catalog). Sometimes these patterns emerge in the code without an explicit discussion on the topic, and they're bound to change as needs shift. In the case of the generator, I only meant that we've recently upgraded to 7.11 for the Python client but weren't able to upgrade further at that point in time. We may be pinned on 7.11 for a while, and I saw that there could be value in aligning this with the rest of the project. If we want to use different versions of the generator for different parts of the code that's totally fine. However when I saw this PR that was: 1. Automated, i.e. without a human owner 2. Old without any community engagement 3. Failing tests 4. Contrary to the trend / "standardization" I mentioned for the Python client I closed it to cut down on the number of open PRs, figuring that we'd reopen it if a good reason to do the upgrade arose at some point down the road. Sorry for any confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
