XJDKC commented on code in PR #1899: URL: https://github.com/apache/polaris/pull/1899#discussion_r2151004917
########## quarkus/defaults/src/main/resources/application.properties: ########## @@ -188,6 +188,9 @@ polaris.oidc.principal-roles-mapper.type=default # polaris.storage.gcp.token=token # polaris.storage.gcp.lifespan=PT1H +# Polaris Entity Transformation Config Review Comment: Also link comment from @dennishuo here: https://github.com/apache/polaris/pull/1805#discussion_r2136212374 > On the one hand, it's useful to be able to have this kind of generalized transformer/mutator hook, but if the hook is also strongly coupled to particular features, we don't want to require separate configuration of the info injection here vs the core feature (e.g. sigv4) somewhere else. > >Especially if we end up having feature configurations for the core feature, then it's important that the feature itself auto-configures itself to be functional. In a way then the classes that define the sigv4 functionality should be what injects the mutator/transformer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
