eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2150995994


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -403,6 +404,20 @@ boolean hasChildren(
       long catalogId,
       long parentId);
 
+  /**
+   * Check if the specified IcebergTableLikeEntity has any same-namespace 
siblings which share a
+   * location
+   *
+   * @param callContext the polaris call context
+   * @param parentId the parent entity to look for duplicates inside
+   * @param location the location to check for overlaps against
+   * @return Optional.of(Optional.of(location)) if the parent entity has 
children,
+   *     Optional.of(Optional.empty()) if not, and Optional.empty() if the 
metastore doesn't support
+   *     this operation
+   */
+  Optional<Optional<String>> hasOverlappingSiblings(
+      @Nonnull PolarisCallContext callContext, long parentId, String location);

Review Comment:
   With the new refactor to use `StorageLocation`, maybe this is more clear?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to