adutra commented on code in PR #1904: URL: https://github.com/apache/polaris/pull/1904#discussion_r2152245351
########## service/common/src/main/java/org/apache/polaris/service/events/AfterAddGrantToCatalogRoleEvent.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.events; + +import org.apache.polaris.core.admin.model.AddGrantRequest; +import org.apache.polaris.core.auth.AuthenticatedPolarisPrincipal; +import org.apache.polaris.core.entity.PolarisPrivilege; + +/** Event fired after a grant is added to a catalog role in Polaris. */ +public class AfterAddGrantToCatalogRoleEvent implements PolarisEvent { Review Comment: Couldn't all these event classes be records? We could even group them in one single file instead of having hundreds of similar files around. ########## service/common/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java: ########## @@ -142,12 +211,24 @@ private PolarisAdminService newAdminService( @Override public Response createCatalog( CreateCatalogRequest request, RealmContext realmContext, SecurityContext securityContext) { + String requestId = PolarisEvent.createRequestId(); Review Comment: A few remarks: Injecting before/after event logic in every method looks like we are mixing concerns. I think the decorator pattern could make things look a lot nicer. About the execution flow: how do we handle errors? E.g. if the listener throws on a before event call, should the execution halt or continue? Also: if the listener throws on an after event call, should the execution be aborted and the persisted changes rolled back, or should the business changes be kept? IOW, are we OK with weaker delivery guarantees for events (like "at most once")? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
