eric-maynard commented on code in PR #1844:
URL: https://github.com/apache/polaris/pull/1844#discussion_r2152664456


##########
service/common/src/main/java/org/apache/polaris/service/events/AfterTableCommitedEvent.java:
##########
@@ -21,14 +21,35 @@
 import org.apache.iceberg.TableMetadata;
 import org.apache.iceberg.catalog.TableIdentifier;
 
-/**
- * Emitted after Polaris performs a commit to a table. This is not emitted if 
there's an exception
- * while committing.
- *
- * @param identifier The identifier.
- * @param base The old metadata.
- * @param metadata The new metadata.
- */
-public record AfterTableCommitedEvent(
-    TableIdentifier identifier, TableMetadata base, TableMetadata metadata)
-    implements PolarisEvent {}
+public final class AfterTableCommitedEvent extends PolarisEvent {

Review Comment:
   I think it's because records can't extend another class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to