flyrain commented on code in PR #1905:
URL: https://github.com/apache/polaris/pull/1905#discussion_r2153433994
##########
getting-started/jdbc/README.md:
##########
@@ -42,7 +42,7 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_PASSWORD=postgres
export ASSETS_PATH=$(pwd)/getting-started/assets/
export CLIENT_ID=root
- export CLIENT_SECRET=s3cr3t
+ export CLIENT_SECRET=secret
Review Comment:
I agreed with @dimas-b for the uniqueness, but the string `secret` was used
in regression tests. To change it to something else will have a bigger impact
on downstream projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
