dimas-b commented on code in PR #1285:
URL: https://github.com/apache/polaris/pull/1285#discussion_r2155266083
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java:
##########
@@ -607,8 +829,15 @@ protected ViewMetadata commit(ViewOperations ops,
UpdateTableRequest request) {
return ops.current();
}
- private int maxCommitRetries() {
+ @VisibleForTesting
+ public int maxCommitRetries() {
return configurationStore.getConfiguration(
realmContext, FeatureConfiguration.ICEBERG_COMMIT_MAX_RETRIES);
}
+
+ @VisibleForTesting
+ public boolean isRollbackCompactionEnabled() {
Review Comment:
Sorry, I missed that. However, would it not be nicer to make this flag a
constructor parameter rather than mocking test values into it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
