gh-yzou commented on code in PR #1933:
URL: https://github.com/apache/polaris/pull/1933#discussion_r2165239034


##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -45,17 +45,7 @@ val scalaLibraryVersion =
 dependencies {
   // TODO: extract a polaris-rest module as a thin layer for
   //  client to depends on.
-  implementation(project(":polaris-core")) {
-    exclude("org.apache.iceberg", "*")
-    exclude("com.azure", "*")
-    exclude("software.amazon.awssdk", "*")
-    exclude("com.google.cloud", "*")
-    exclude("io.airlift", "*")
-    exclude("io.smallrye", "*")
-    exclude("io.smallrye.common", "*")
-    exclude("io.swagger", "*")
-    exclude("org.apache.commons", "*")
-  }
+  implementation(project(":polaris-core")) { isTransitive = false }

Review Comment:
   Yes, there is a TODO on top to put the class that can be shared between 
client and server into a different module, and the module can potentially be 
used by other clients that would like to talk to polaris



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to