eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2165624916


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -403,6 +406,19 @@ boolean hasChildren(
       long catalogId,
       long parentId);
 
+  /**
+   * Check if the specified IcebergTableLikeEntity / NamespaceEntity has any 
sibling entities which
+   * share a base location
+   *
+   * @param callContext the polaris call context
+   * @param entity the entity to check for overlapping siblings for
+   * @return Optional.of(Optional.of(location)) if the parent entity has 
children,
+   *     Optional.of(Optional.empty()) if not, and Optional.empty() if the 
metastore doesn't support
+   *     this operation
+   */
+  <T extends PolarisEntity & LocationBasedEntity> Optional<Optional<String>> 
hasOverlappingSiblings(

Review Comment:
   No, I definitely don't think we want to throw. Like was noted above, we want 
to let persistence implementations decide whether they want to support this 
check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to