eric-maynard commented on code in PR #1938:
URL: https://github.com/apache/polaris/pull/1938#discussion_r2167134069
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/EntitiesResult.java:
##########
@@ -48,41 +43,19 @@ public static EntitiesResult
fromPage(Page<PolarisBaseEntity> page) {
public EntitiesResult(@Nonnull ReturnStatus errorStatus, @Nullable String
extraInformation) {
super(errorStatus, extraInformation);
this.entities = null;
- this.pageTokenOpt = Optional.empty();
- }
-
- public EntitiesResult(@Nonnull List<PolarisBaseEntity> entities) {
- this(entities, Optional.empty());
}
/**
* Constructor for success
*
* @param entities list of entities being returned, implies success
*/
- public EntitiesResult(
- @Nonnull List<PolarisBaseEntity> entities, @Nonnull Optional<PageToken>
pageTokenOpt) {
+ public EntitiesResult(@Nonnull Page<PolarisBaseEntity> entities) {
super(ReturnStatus.SUCCESS);
this.entities = entities;
- this.pageTokenOpt = pageTokenOpt;
- }
-
- @JsonCreator
- private EntitiesResult(
Review Comment:
If we can avoid it, I think it's better not to change this. This will be a
breaking change for any persistence implementation depending on
wire-compatibility of the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
