harishch1998 commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2167392624
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -700,16 +700,9 @@ private Map<String, UserSecretReference>
extractSecretReferences(
/**
* @see #extractSecretReferences
*/
- private boolean requiresSecretReferenceExtraction(CreateCatalogRequest
catalogRequest) {
- Catalog catalog = catalogRequest.getCatalog();
- if (catalog instanceof ExternalCatalog externalCatalog) {
- if (externalCatalog.getConnectionConfigInfo() != null) {
- // TODO: Make this more targeted once we have connection configs that
don't involve
- // processing of inline secrets.
- return true;
- }
- }
- return false;
+ private boolean requiresSecretReferenceExtraction(ConnectionConfigInfo
connectionConfigInfo) {
Review Comment:
nit: Can add @NotNull here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
