snazy commented on code in PR #1918:
URL: https://github.com/apache/polaris/pull/1918#discussion_r2162927182
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,13 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log
messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
+# Prevent the 'The Agroal dependency is present but no JDBC datasources have
been defined.' built-time warning.
+quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
Review Comment:
removed application-test
##########
runtime/service/src/test/resources/logback-test.xml:
##########
@@ -29,4 +29,11 @@
<root level="${log.level.console:-INFO}">
<appender-ref ref="console"/>
</root>
+
+ <!--
+ Prevent the 'The Agroal dependency is present but no JDBC datasources have
been defined.' build-time warning.
+ See
https://github.com/quarkusio/quarkus/blob/2fbc20f445fad43aaf4f3f984b9ac8319c7c7f0a/extensions/agroal/deployment/src/main/java/io/quarkus/agroal/deployment/AgroalProcessor.java#L111
+ THIS IS A TECHNICAL NECESSITY, because of the
+ -->
+ <logger name="io.quarkus.agroal.deployment" level="ERROR"/>
Review Comment:
So - that warning is odd. It may or may not appear. But I cannot figure out
why ... it did not appear yesterday but now it does again... But I'm not going
to spend days on a log message
##########
runtime/admin/src/test/java/org/apache/polaris/admintool/relational/jdbc/RelationalJdbcAdminProfile.java:
##########
@@ -18,7 +18,7 @@
*/
package org.apache.polaris.admintool.relational.jdbc;
-import static
org.apache.polaris.admintool.PostgresTestResourceLifecycleManager.INIT_SCRIPT;
+import static
org.apache.polaris.admintool.PostgresEclipselinkTestResourceLifecycleManager.INIT_SCRIPT;
Review Comment:
It's been there before :shrug:
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,10 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log
messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
Review Comment:
Looks like the test-port settings aren't necessary - seems there was
something else at play
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
