jbonofre commented on code in PR #1926:
URL: https://github.com/apache/polaris/pull/1926#discussion_r2166925250


##########
runtime/distribution/build.gradle.kts:
##########
@@ -104,6 +104,7 @@ distZip.configure { finalizedBy(digestDistZip) }
 
 if (project.hasProperty("release") || project.hasProperty("signArtifacts")) {
     signing {
+        useGpgCmd();

Review Comment:
   I can see in 
https://github.com/apache/polaris/blob/main/build-logic/src/main/kotlin/publishing/PublishingHelperPlugin.kt#L107
 that `useGpgCmd()` is used when the `useGpgAgent` is set.
   
   I just tried the `./gradlew build sourceTarball -Prelease -PuseGpgAgent -x 
test -x intTest` command and it works fine for me:
   
   ```
   Configuration on demand is an incubating feature.
   
   > Task :signSourceTarball
   gpg: WARNING: "--no-use-agent" is an obsolete option - it has no effect
   ...
   > Task :releaseEmailTemplate
   
   
   The email for your release vote mail:
   -------------------------------------
   ...
   BUILD SUCCESSFUL in 52s
   671 actionable tasks: 367 executed, 304 up-to-date
   ```
   
   I just did two things:
   1. I checked the GPG tty is correct (as I'm using screen) with `export 
GPG_TTY=$(tty)`
   2. I "activated" the gpg-agent just by doing to dummy clear sign:
   
   ```
   gpg --clearsign
   ```
   
   This is just to be sure gpg-agent process is running.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to