pavibhai commented on code in PR #1932:
URL: https://github.com/apache/polaris/pull/1932#discussion_r2173832373
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java:
##########
@@ -79,7 +80,7 @@ public void testGetSubscopedCreds() {
.returns(roleARN, AssumeRoleRequest::roleArn);
return ASSUME_ROLE_RESPONSE;
});
- String warehouseDir = "s3://bucket/path/to/warehouse";
+ String warehouseDir = scheme + "://bucket/path/to/warehouse";
Review Comment:
@flyrain I have adjusted the test in
`AwsCredentialsStorageIntegrationTest:testGetSubscopedCreds` to validate that
the policy that we generate does not have any references to S3A.
This should be sufficient proof on this until we get to the test in
`regtests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
