eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2175804445
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -263,12 +264,14 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(true)
.buildFeatureConfiguration();
- public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
- PolarisConfiguration.<List<String>>builder()
- .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
- .description("The list of supported catalog connection types for
federation")
- .defaultValue(List.of(ConnectionType.ICEBERG_REST.name()))
- .buildFeatureConfiguration();
+ public static final FeatureConfiguration<List<String>>
+ SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_EXTERNAL_CATALOG_CONNECTION_TYPES")
+ .deprecatedKey("SUPPORTED_CATALOG_CONNECTION_TYPES")
Review Comment:
I think if we're really doing this we need to take multiple keys, so like
`PolarisConfiguration.<>builder().keys(...)`. Maybe that should take some
`ConfigurationKey`, or maybe we should have some other mechanism for marking
which are deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
