eric-maynard commented on code in PR #1942: URL: https://github.com/apache/polaris/pull/1942#discussion_r2175814469
########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatasourceOperations.java: ########## @@ -75,46 +76,51 @@ DatabaseType getDatabaseType() { } /** - * Execute SQL script. + * Execute SQL script and close the associated input stream Review Comment: That sounds like a good idea... is this [the one from jsr305](https://www.javadoc.io/static/com.google.code.findbugs/jsr305/3.0.2/javax/annotation/WillClose.html)? It doesn't seem that we have that dependency currently, and we're not using it anywhere else in the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org