eric-maynard commented on PR #1986: URL: https://github.com/apache/polaris/pull/1986#issuecomment-3030383506
@HonahX > Do we want to add python format check to gradle because we want format issue stops CI before enterring the real test cases? I'd like to have the same setup as the rest of the code -- CI fails if you have a format issue, and `./gradlew format` fixes it. > IMHO, the python client should be isolated from the main java project and all the dependency management/test/checking should happen with in that folder via poetry and some other python specific tools. And format failure or test failure should not cause irrelevant CI workflow to fail (e.g. Java Gradle test) It makes sense to use python-specific tooling (ruff?) and to have python-specific commands... but the gradle task `checkstyleMain` isn't called `checkStyleJava`. We already check the python code in the gradle task `copiedCodeChecks` and as you pointed out we also have the (short-lived?) gradle task `regeneratePythonClient`. Having a gradle task to check/fix style issues seems convenient and not a huge leap from what we already have. Agreed that irrelevant CI shouldn't fail -- but there actually is no CI action called Jave Gradle test... `Regression Tests` is failing, for example, but that's not Java specific and in fact runs Python code today. The Python CI should ideally fail if there are Python style issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
