gh-yzou commented on code in PR #1997:
URL: https://github.com/apache/polaris/pull/1997#discussion_r2183935286
##########
plugins/spark/v3.5/regtests/setup.sh:
##########
@@ -129,11 +135,27 @@ else
echo 'Setting spark conf...'
# Instead of clobbering existing spark conf, just comment it all out in case
it was customized carefully.
sed -i 's/^/# /' ${SPARK_CONF}
-cat << EOF >> ${SPARK_CONF}
+# If POLARIS_CLIENT_JAR is provided, set the spark conf to use the jars
configuration.
+# Otherwise use the packages setting
+if [[ -z "$POLARIS_CLIENT_JAR" ]]; then
+ cat << EOF >> ${SPARK_CONF}
+# POLARIS Spark client test conf
+spark.jars.packages
org.apache.polaris:polaris-spark-3.5_$SCALA_VERSION:$POLARIS_VERSION,io.delta:delta-spark_${SCALA_VERSION}:3.2.1
+EOF
+else
+ cat << EOF >> ${SPARK_CONF}
# POLARIS Spark client test conf
spark.jars $POLARIS_CLIENT_JAR
spark.jars.packages io.delta:delta-spark_${SCALA_VERSION}:3.2.1
+EOF
+fi
+
+# spark.jars $POLARIS_CLIENT_JAR
+# spark.jars.packages io.delta:delta-spark_${SCALA_VERSION}:3.2.1
Review Comment:
oh, that is just a missed cleanup, removed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
