adutra commented on code in PR #2002:
URL: https://github.com/apache/polaris/pull/2002#discussion_r2190569573
##########
helm/polaris/values.yaml:
##########
@@ -583,18 +583,27 @@ authentication:
# -- The type of token broker to use. Two built-in types are supported:
rsa-key-pair and symmetric-key.
tokenBroker:
type: rsa-key-pair # symmetric-key
+ # -- Maximum token generation duration (e.g., PT1H for 1 hour).
maxTokenGeneration: PT1H
# -- The secret name to pull the public and private keys, or the symmetric
key secret from.
secret:
# -- The name of the secret to pull the keys from. If not provided, a
key pair will be generated.
# This is not recommended for production.
name: ~
- # -- The public key file to use for RSA key pair token broker. Only
required when using rsa-key-pair.
+
publicKey: public.pem
Review Comment:
```suggestion
```
##########
helm/polaris/values.yaml:
##########
@@ -583,18 +583,27 @@ authentication:
# -- The type of token broker to use. Two built-in types are supported:
rsa-key-pair and symmetric-key.
tokenBroker:
type: rsa-key-pair # symmetric-key
+ # -- Maximum token generation duration (e.g., PT1H for 1 hour).
maxTokenGeneration: PT1H
# -- The secret name to pull the public and private keys, or the symmetric
key secret from.
secret:
# -- The name of the secret to pull the keys from. If not provided, a
key pair will be generated.
# This is not recommended for production.
name: ~
- # -- The public key file to use for RSA key pair token broker. Only
required when using rsa-key-pair.
+
publicKey: public.pem
- # -- The private key file to use for RSA key pair token broker. Only
required when using rsa-key-pair.
privateKey: private.pem
- # -- The symmetric key file to use for symmetric key token broker. Only
required when using symmetric-key.
secretKey: secret
Review Comment:
```suggestion
```
##########
helm/polaris/values.yaml:
##########
@@ -583,18 +583,27 @@ authentication:
# -- The type of token broker to use. Two built-in types are supported:
rsa-key-pair and symmetric-key.
tokenBroker:
type: rsa-key-pair # symmetric-key
+ # -- Maximum token generation duration (e.g., PT1H for 1 hour).
maxTokenGeneration: PT1H
# -- The secret name to pull the public and private keys, or the symmetric
key secret from.
secret:
# -- The name of the secret to pull the keys from. If not provided, a
key pair will be generated.
# This is not recommended for production.
name: ~
- # -- The public key file to use for RSA key pair token broker. Only
required when using rsa-key-pair.
+
publicKey: public.pem
- # -- The private key file to use for RSA key pair token broker. Only
required when using rsa-key-pair.
privateKey: private.pem
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
