eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190638411
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java:
##########
@@ -64,9 +92,13 @@ public static boolean
isTableWithSparkManagedLocation(Map<String, String> proper
* Load spark table using DataSourceV2.
*
* @return V2Table if DataSourceV2 is available for the table format. For
delta table, it returns
- * DeltaTableV2.
+ * DeltaTableV2. For hudi it should return HoodieInternalV2Table.
*/
- public static Table loadSparkTable(GenericTable genericTable) {
+ public static Table loadSparkTable(GenericTable genericTable, Identifier
identifier) {
+ if (genericTable.getFormat().equalsIgnoreCase("hudi")) {
+ // hudi does not implement table provider interface, so will need to
catch it
Review Comment:
1. But you're not catching anything here
2. Sounds like a limitation on the Hudi side; maybe it makes sense for us to
only support `V2TableProviderInterface` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
