adutra commented on code in PR #2001: URL: https://github.com/apache/polaris/pull/2001#discussion_r2190756015
########## helm/polaris/README.md.gotmpl: ########## @@ -198,27 +157,18 @@ The following tools are required to run the tests: * [Chart Testing](https://github.com/helm/chart-testing) Quick installation instructions for these tools: - ```bash helm plugin install https://github.com/helm-unittest/helm-unittest.git brew install chart-testing ``` -The integration tests also require some fixtures to be deployed. The `ci/fixtures` directory -contains the required resources. To deploy them, run the following command: +The integration tests also require some fixtures to be deployed. Follow the above commands to setup required resources. -```bash -kubectl apply --namespace polaris -f helm/polaris/ci/fixtures/ -kubectl wait --namespace polaris --for=condition=ready pod --selector=app.kubernetes.io/name=postgres --timeout=120s -``` - -The `helm/polaris/ci` contains a number of values files that will be used to install the chart with -different configurations. +The `helm/polaris/ci` contains a number of values files that will be used to install the chart with different configurations. ### Running the unit tests -Helm unit tests do not require a Kubernetes cluster. To run the unit tests, execute Helm Unit from -the Polaris repo root: +Helm unit tests do not require a Kubernetes cluster. To run the unit tests, execute Helm Unit from the Polaris repo root: Review Comment: The thing is, we don't have a rule for that (at least, not that I know of). So going back and forth from single-line to multi-line without changing the actual words seems a rather bad practice, because it adds visual clutter for reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
