eric-maynard commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191020935


##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
                   + "to enforce this when new locations are added. Only 
supported by the JDBC metastore.")
           .defaultValue(false)
           .buildFeatureConfiguration();
+
+  public static final FeatureConfiguration<Boolean> 
DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED =
+      PolarisConfiguration.<Boolean>builder()
+          .key("DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED")

Review Comment:
   Ah, yeah, the naming is really tough here. It's `DEFAULT_LOCATION ...` 
because it alters the "default location" given to a table if there is no 
user-specified location. 
   
   The Iceberg feature doesn't have this component because it applies _within_ 
the user-specified table location, whereas the Polaris feature applies above 
the table location only if there isn't a user-specified location.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to